Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing litestar pytest marker #3702

Conversation

DoctorJohn
Copy link
Member

@DoctorJohn DoctorJohn commented Nov 17, 2024

Description

This PR fixes thes following pytest warning: PytestUnknownMarkWarning: Unknown pytest.mark.litestar - is this a typo? You can register custom marks to avoid this warning

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Summary by Sourcery

Enhancements:

  • Add 'litestar' to the list of registered pytest markers in pyproject.toml to prevent PytestUnknownMarkWarning.

Copy link
Contributor

sourcery-ai bot commented Nov 17, 2024

Reviewer's Guide by Sourcery

The PR adds the missing 'litestar' pytest marker to the pytest configuration in pyproject.toml to resolve a warning about an unknown marker. The change is straightforward and only involves adding a single line to the markers list while maintaining alphabetical order.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added missing pytest marker configuration
  • Added 'litestar' to the pytest markers list
  • Maintained alphabetical ordering of markers
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@botberry
Copy link
Member

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @NucleonJohn for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #3702 will not alter performance

Comparing DoctorJohn:fix-missing-starlite-pytest-marker (f5d9aa3) with main (4920f1e)

Summary

✅ 15 untouched benchmarks

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (04936fd) to head (f5d9aa3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3702   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         502      502           
  Lines       33568    33571    +3     
  Branches     5634     5635    +1     
=======================================
+ Hits        32565    32568    +3     
  Misses        796      796           
  Partials      207      207           

@patrick91 patrick91 merged commit 0e2669f into strawberry-graphql:main Nov 18, 2024
109 of 110 checks passed
@DoctorJohn DoctorJohn deleted the fix-missing-starlite-pytest-marker branch November 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants